Skip to content

Split follow ups #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tony merged 6 commits into from
Mar 17, 2024
Merged

Split follow ups #534

tony merged 6 commits into from
Mar 17, 2024
+26 −1

Conversation

@tony
Copy link
Member

@tony tony commented Mar 17, 2024 •
edited
Loading

Follow up to #532

Changes

Split fixes

  • Keyword-only style arguments
  • Fix passing through target

New window fixes

  • Fix window_index

@codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.66%. Comparing base (fe27280) to head (271f7b9).

Files Patch % Lines
src/libtmux/pane.py 0.00% 1 Missing and 1 partial ⚠️
src/libtmux/session.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   88.72%   88.66%   -0.07%     
==========================================
  Files          37       37              
  Lines        3965     3969       +4     
  Branches      573      575       +2     
==========================================
+ Hits         3518     3519       +1     
- Misses        307      308       +1     
- Partials      140      142       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the split-followups branch from 7c9ae40 to 84f1b5f Compare March 17, 2024 10:45
@tony tony force-pushed the split-followups branch from aa859d2 to c5c0d5d Compare March 17, 2024 10:50
@tony tony force-pushed the split-followups branch from c5c0d5d to 6215bdb Compare March 17, 2024 10:56
@tony tony force-pushed the split-followups branch from 1770698 to 64e0aba Compare March 17, 2024 11:49
@tony tony force-pushed the split-followups branch from c8c6657 to 271f7b9 Compare March 17, 2024 11:56
@tony tony merged commit eb8f81b into master Mar 17, 2024
@tony tony deleted the split-followups branch March 17, 2024 11:58
tony added a commit that referenced this pull request Mar 17, 2024
@tony
Tag v0.33.0b1 (#534 fixes)
12d4e68
tony added a commit that referenced this pull request Mar 17, 2024
@tony
Tag v0.33.0 (#532 and #534)
42dcfc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tony